[Webkit-unassigned] [Bug 60757] [CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 11:58:06 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60757





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-05-13 11:58:06 PST ---
(In reply to comment #2)
> (In reply to comment #0)
> > cairo_image_surface_create_for_data() is already a shallow copy of the image, so we don't need to copy it again.
> 
> Notice that in ShareableBitmapCG.cpp (the CG version of this file), the code does a copy of the image. Perhaps that this is just to support self copies though. If that's the case, it would be better to support self-copies by detecting when the target of the context is the same as the ShareableBitmap. Please contect the Apple team to see what the correct behavior is here.

But we are creating a new surface and copying that new surface, CG copies the already existing image, I think, which is the same than simply create a new surface with the image data.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list