[Webkit-unassigned] [Bug 60638] check-webkit-style should warn about types we normally pass as reference

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60638





--- Comment #9 from Levi Weintraub <leviw at chromium.org>  2011-05-13 10:44:54 PST ---
(In reply to comment #8)
> It looks like people are being guided to using "const IntPoint&"
> 
> https://bugs.webkit.org/show_bug.cgi?id=60679#c5
> 
> Perhaps the guideline is if it begins with a capital letter (aka a custom defined type), then it is a pass by ref (const is optional) or pointer but not by value.
> 
> Then if there are exceptions to this rule we can special case those types. To say that they should be pass by value, but it sounds like IntPoint is not an exception.

I'd just like to see a consensus so we can avoid butting heads on individual bugs when which is best could be argued.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.