[Webkit-unassigned] [Bug 60157] Gradients not horizontal using 270deg with odd div width

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 09:25:12 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60157


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93460|review?                     |review-
               Flag|                            |




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-05-13 09:25:12 PST ---
(From update of attachment 93460)
View in context: https://bugs.webkit.org/attachment.cgi?id=93460&action=review

The code change looks good but I'd like to see the test tweaked.

> LayoutTests/fast/gradients/css3-linear-right-angle-gradients.html:6
> +<title>
> +    Test that computation of right angle (90, 180, 270) linear gradients is done properly.
> +</title>

This should be a dumpAsText(true) test. Also, it would be better if the divs were squares (inline-block to make them line up), and don't use red if red is expected in the test result.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list