[Webkit-unassigned] [Bug 60773] New: Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60773

           Summary: Web Inspector: Fix SourceJavaScriptTokenizer keyword
                    parsing
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: apavlov at chromium.org
                CC: timothy at apple.com, rik at webkit.org, keishi at webkit.org,
                    pmuellr at yahoo.com, joepeck at webkit.org,
                    pfeldman at chromium.org, yurys at chromium.org,
                    bweinstein at apple.com, apavlov at chromium.org,
                    loislo at chromium.org


SourceJavaScriptTokenizer has two issues with keyword parsing:
1. Keywords are tested as "token in this._keywords", thus "__proto__" and all methods found on a generic objects (e.g. "toString" are considered to be keywords)
2. "true}" is parsed as a single "javascript-ident", since the
yych = "}"; if (yych <= 0x7F)...
check always fails (JavaScript does not define comparisons of strings vs. integers the way we need).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.