[Webkit-unassigned] [Bug 45274] Breaking Float: floated block level element following inline element in floated container breaks to next line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45274





--- Comment #26 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2011-05-13 07:34:52 PST ---
(In reply to comment #25)
> ChangSeok, are you going to address the comments?
> 
> Especially with the recent refactoring going on within this file, getting
> a patch to land would be great, otherwise it will go stale quickly.
> 
> 
> > > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2119
> > > +            if (currentCharacterIsSpace && additionalTmpW)
> > > +                width.setAdditionalWidth(additionalTmpW);
> > 
> > It seems wrong not to include inlineLogicalWidth here.  You might
> > want to make a test for this case.  You should be able to just add
> > it to additionalTmpW I would think.
> 
> > Also, checking currentCharacterIsSpace seems suspicious to me
> > without also checking the whitespace mode.
> 
> Hyatt, did you have example tests in mind for these?

Sorry for late response. I'm a little busy recently.
I'll have a look again and give you a proper response as soon as possible.
Thank you :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.