[Webkit-unassigned] [Bug 60690] [CMAKE] Remove -Wcast-align

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60690


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossy at webkit.org




--- Comment #8 from Antonio Gomes <tonikitoo at webkit.org>  2011-05-13 06:38:15 PST ---
That is an intesresting point. Ossy, have you seen and fixed it on Qt (arm builds)? We see this a lot on our BlackBerry port as well, so a fix would not be so bad :)

(In reply to comment #7)
> (From update of attachment 93400 [details])
> It warns only on ARM because on x86 integers can be accessed other than on 4-byte boundaries. This means this warning is irrelevant on x86.
> 
> I'm wondering if we shouldn't fix these casts instead of removing the warnings. A quick grep reveals that both GTK and QT use -Wcast-align:
> 
> $ find . -name '*.pri' -exec grep Wall {} \;
> *-g++*:QMAKE_CXXFLAGS += -Wall -Wextra -Wreturn-type -fno-strict-aliasing -Wcast-align -Wchar-subscripts -Wformat-security -Wreturn-type -Wno-unused-parameter -Wno-sign-compare -Wno-switch -Wno-switch-enum -Wundef -Wmissing-noreturn -Winit-self
> 
> $ find . -name GNUmakefile.am -exec grep -B1 -A5 Wall {} \;
> global_cppflags += \
>     -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type \
>     -Wformat -Wformat-security -Wno-format-y2k -Wundef \
>     -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings \
>     -Wno-unused-parameter -Wno-parentheses \
>     -fno-exceptions -DENABLE_GLIB_SUPPORT=1

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.