[Webkit-unassigned] [Bug 58652] Web Inspector: Background network events collection - add GUI to Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58652





--- Comment #17 from Yury Semikhatsky <yurys at chromium.org>  2011-05-13 04:13:59 PST ---
(From update of attachment 93419)
View in context: https://bugs.webkit.org/attachment.cgi?id=93419&action=review

Overall looks good except a couple of minor suggestions.

> LayoutTests/http/tests/inspector/network-test.js:3
> +InspectorTest.enableBackgroundEventCollection = function()

This method is not used anymore, please remove it.

> LayoutTests/http/tests/inspector/network-test.js:9
> +InspectorTest.enableBackgroundEventCollectionInsure = function()

I think it can be just enableBackgroundEventCollection, or ensureBackgroundEventCollectionEnabled if you prefer the latter form.

> LayoutTests/http/tests/inspector/network/network-open-load-reopen.html:56
> +Test that when background event collection is enabled network panel correctly restores network log after the frontend reopening.

It's a good practice to put a link to the bug into the test description.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.