[Webkit-unassigned] [Bug 59596] Web Inspector: Move Resources Panel search to backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59596


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91680|review?                     |
               Flag|                            |




--- Comment #12 from Pavel Feldman <pfeldman at chromium.org>  2011-05-12 13:02:15 PST ---
(From update of attachment 91680)
View in context: https://bugs.webkit.org/attachment.cgi?id=91680&action=review

Couple of nits, otherwise looks good.

> Source/WebCore/inspector/Inspector.json:107
> +                    { "name": "matchesCount", "type": "number", "description": "Number of matches in resource content." }

in _the_ resource content.

> Source/WebCore/inspector/InspectorPageAgent.cpp:531
> +void InspectorPageAgent::domContentEventFired()

I thought these were already a part of the file.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:706
> +                    var resource = frameTreeElement.resourceByURL(searchResult.url);

You should check frame tree elements for null - they are very dynamic.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.