[Webkit-unassigned] [Bug 60585] Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 12:19:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60585


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93323|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #13 from Darin Adler <darin at apple.com>  2011-05-12 12:19:48 PST ---
(From update of attachment 93323)
View in context: https://bugs.webkit.org/attachment.cgi?id=93323&action=review

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:329
> +        IntPoint location(width() - borderRight() - paddingRight() - spinBox->width(),
> +                          (diff / 2) + (diff % 2));

This indentation is not the WebKit coding style. I think you should just add IntPoint around (x,y) instead of changing the code so much.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list