[Webkit-unassigned] [Bug 60194] REGRESSION (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 12:07:47 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60194


Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamesr at chromium.org




--- Comment #15 from Adam Roben (:aroben) <aroben at apple.com>  2011-05-12 12:07:47 PST ---
I talked to James Robinson and came up with a plan. Here are some snippets of our conversation in IRC:

<aroben> jamesr: including the call to frameRectsChanged
<aroben> jamesr: this was done on the assumption that scrollbars didn't need to be respositioned when the ScrollView is repositioned
<aroben> jamesr: (I guess that means that scrollbars are positioned relative to the ScrollView, and move along with it automatically)
<jamesr> they are, yeah
<aroben> jamesr: that change caused https://bugs.webkit.org/show_bug.cgi?id=60194 because frameRectsChanged did more than just reposition scrollbars
<aroben> jamesr: so I'm trying to figure out how to fix it
<jamesr> my vague recollection is that setFrameRects did a whole lot and it wasn't clear to me what it should or shouldn't be doing
<aroben> jamesr: I could move the positionScrollbarLayers call out of frameRectsChanged
<jamesr> the call is there to try to catch adding/removing scrollbars, i think
<jamesr> aroben: the other difficulty for you is that scrollbar layers are only created on the mac port when overlay scrollbars are in use, and last i checked DumpRenderTree did not use overlay scrollbars on any platform
<aroben> jamesr: frameRectsChanged is called in four places: 1) updateScrollbars (when scrollbars are added/removed), 2) scrollContents, 3) setBoundsSize, 4) recursively from frameRectsChanged
<jamesr> yeah, you should only need the positionScrollbarLayers() call in (1) and (3)
<aroben> jamesr: ok, so maybe I should call positionScrollbarLayers() explicitly in those two places and move it out of frameRectsChanged
<aroben> jamesr: and then move the frameRectsChanged call back from setBoundsSize to setFrameRect
<jamesr> aroben: that sounds like it should work!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list