[Webkit-unassigned] [Bug 60585] Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 11:19:53 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60585





--- Comment #7 from Darin Adler <darin at apple.com>  2011-05-12 11:19:53 PST ---
(In reply to comment #6)
> the difference between lround and other similar rounding functions such rint is the handling of the half way case

We should never use rint because we don’t want our code’s behavior to change based on the prevailing rounding mode. For some reason roundedIntPoint uses roundf, but it should probably use lroundf.

I don’t see why we can’t use roundedIntPoint here. Does it give the wrong results for something?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list