[Webkit-unassigned] [Bug 58652] Web Inspector: Background network events collection - add GUI to Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58652





--- Comment #12 from Sergey Vorobyev <sergeyvorobyev at google.com>  2011-05-12 11:08:29 PST ---
(From update of attachment 93110)
View in context: https://bugs.webkit.org/attachment.cgi?id=93110&action=review

>> LayoutTests/http/tests/inspector/inspector-test.js:343
>> +    setTimeout(function() {
> 
> Why do we need this setTimeout?

Probably no reasons. I remove it.

>> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:8
>> +    var size = 400 + 200 * loadedResourceCount;
> 
> What's the purpose of this expression? It looks like you can use some arbitrary numbers to get two different URLs.

Exactly. It's look confusing, yeah. I fix it.

>> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:34
>> +            WebInspector.panels.network._toggleBackgroundEventsCollection();
> 
> Which state is it supposed to go in? Is it possible that the background collection is already on? Would be better to call something like enableBackgroundEventCollection that would make sure that the new state is on, no matter what the previous state was.

done

>> LayoutTests/http/tests/inspector/network/network-clear-after-disabled.html:61
>> +Test that network panel is empty after reopening. Even if before reopening resources are loading in background collection mode.
> 
> It's hard to understand what the test does from the description, could you change the wording?

Test that reopening clears network panel in background events collection disabled mode.

>> LayoutTests/http/tests/inspector/network/network-close-load-open.html:8
>> +    size = 400;
> 
> This can be inlined.

done

>> LayoutTests/http/tests/inspector/network/network-close-load-open.html:44
>> +            WebInspector.panels.network._toggleBackgroundEventsCollection();
> 
> There should be a more reliable way of doing this so that even if the test fails background collection would be turned off.

done. But not pure safe. We need add InspectorTest.disableBackgroundEventCollection call to InspectorTest.completeTest for really safety.

>> LayoutTests/http/tests/inspector/network/network-open-load-reopen.html:55
>> +Test that when background event collection is enabled network panel correctly restores network log after the frontend reopening.
> 
> What's the difference between this test and network-close-load-open.html ?

Different in actions sequences.
open-load-reopen test that collection work with opened frontend
close-load-open test that collection work with closed frontend

>> Source/WebCore/ChangeLog:9
>> +        "Backgroune events collection". It's allows save all network events when inspector
> 
> Backgroune -> Background. It's allows save -> It allows to save

done.

>> Source/WebCore/ChangeLog:10
>> +        frontend closed. Events occasion before collection enabling are not preserved after
> 
> Events that occur before...

done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.