[Webkit-unassigned] [Bug 60247] Handle the touch icon in WebKit/Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60247


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93193|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #40 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-05-12 09:50:26 PST ---
(From update of attachment 93193)
View in context: https://bugs.webkit.org/attachment.cgi?id=93193&action=review

> Source/WebKit/chromium/ChangeLog:9
> +        Added a parameter to favIconURL() to specify the type of icon need to

this is a bit stale.  it should also mention the method renaming.

> Source/WebKit/chromium/public/WebFrame.h:133
> +    // This method is deprecated and will be removed soon.

nit: we usually format comments like this for easy discovery later.

// DEPRECATED: Use iconIRLs instead.

> Source/WebKit/chromium/public/WebFrameClient.h:205
> +    // This method is deprecated and will be removed soon.

same nit...

// DEPRECATED: Implement didChangeIcon instead.

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:764
> +        // Keep the API work in the transient.

nit: this a good place to insert FIXME, again for easy discovery later.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:531
> +WebVector<WebIconURL> WebFrameImpl::iconURLs(int webIconTypes) const

nit: param should just be called iconTypes as it is declared in the header.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.