[Webkit-unassigned] [Bug 60563] [Chromium]Click event is not fired for a menulist <select>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60563


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93236|review?                     |review-
               Flag|                            |




--- Comment #11 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-05-12 09:45:37 PST ---
(From update of attachment 93236)
View in context: https://bugs.webkit.org/attachment.cgi?id=93236&action=review

I think you're almost there. For the most natural way, try handing this off to eventHandler::handleMouseRelease in AutoFillPopuMenuClient?

> Source/WebCore/rendering/RenderMenuList.cpp:314
> +    node()->dispatchMouseEvent(event, eventNames().mouseupEvent);
> +    node()->dispatchMouseEvent(event, eventNames().clickEvent);

This logic is probably a bit more complicated than this. When you mouse down on a menu, then move the mouse off the menu, should the click still be dispatched? That's not how normal DOM works. See http://codesearch.google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/page/EventHandler.cpp&l=1666&exact_package=chromium. Perhaps you should just hand this to EventHandler?

> Source/WebCore/rendering/RenderTextControlSingleLine.h:118
> +    virtual void dispatchMouseUpAndClick(const PlatformMouseEvent&) { }

This is definitely wrong. We shouldn't dispatch events from RenderObjects.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.