[Webkit-unassigned] [Bug 55257] Support creating compositing layers for scrollable frames and iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55257





--- Comment #42 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-05-11 18:16:11 PST ---
(From update of attachment 89651)
View in context: https://bugs.webkit.org/attachment.cgi?id=89651&action=review

Still not a big fan of this change.

> Source/WebCore/page/FrameView.cpp:948
> +        if (root->view()->document()->frame()->tree()->parent())

There has to be a better way than root->view()->document()->frame()->tree()->parent()

> Source/WebCore/page/FrameView.cpp:949
> +            compositor->setForceCompositingMode(compositor->requiresCompositingForScrollableFrame(view) ? true : false);

No need for foo ? true : false.

Also, this could be just one method on the compositor: compositor->forceCompostingForScrollableFrame().

So you want scrollable frames to composite even if nothing else is triggering composting mode? Why not just always use compositing?

> Source/WebCore/page/Settings.h:313
> +        void setAcceleratedCompositingForScrollableFrameEnabled(bool);
> +        bool acceleratedCompositingForScrollableFrameEnabled() const { return m_acceleratedCompositingForScrollableFrameEnabled; }

I'd name these acceleratedCompositingForScrollableFrame_s_Enabled

I don't really like the fact that you're adding a setting. Will this get toggled at runtime? Can it just be a compile-time thing?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1278
> +    if (!ownerElement || (!ownerElement->hasTagName(iframeTag) && !ownerElement->hasTagName(frameTag)))
> +        return false;

What about <object src="foo.html">?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.