[Webkit-unassigned] [Bug 49543] [GTK] Improve FrameLoader signals. Resource loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49543





--- Comment #25 from Martin Robinson <mrobinson at webkit.org>  2011-05-11 17:29:35 PST ---
(From update of attachment 93083)
View in context: https://bugs.webkit.org/attachment.cgi?id=93083&action=review

This looks pretty good to me, in general. I think Gustavo or Xan should sign off on the API changes now.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:185
>      DATABASE_QUOTA_EXCEEDED,
> -    RESOURCE_REQUEST_STARTING,
>      DOCUMENT_LOAD_FINISHED,

I think reordering the signals is an ABI break unfortunatley.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2803
> +    /*
> +     * WebKitWebView::resource-content-length-received
> +     * @webView: the object which received the signal
> +     * @webFrame: the #WebKitWebFrame the response was received for
> +     * @webResource: the #WebKitWebResource that was loaded
> +     * @lengthReceived: the resource data length in bytes
> +     *
> +     * Emitted when all the data for the resource was loaded
> +     *
> +     * Since: 1.5.1
> +     */

This documentation appears to be incorrect.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1115
> +    if (webResource == webkit_web_data_source_get_main_resource(dataSource)
> +        && (!webkit_web_view_get_progress(webView) || g_str_equal(uri->scheme, "file")))
> +        description = CString("<unknown>");

This is slightly different than before where you were getting the main resource from the main frame, right? I'm not sure which is correct, because I'm not sure exactly what this is doing. Why do we only return "<unknown>" if this is the main data source of the frame? This probably needs a comment.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1184
> +        printf("%s - willSendRequest %s redirectResponse %s\n", path.data(),
> +               requestDescription.data(), responseDescription.data());

Can just be:
 printf("%s - willSendRequest %s redirectResponse %s\n",
        convertNetworkRequestToURLPath(request).data(),
        requestDescription(descriptionSuitableForTestResult(request)).data(),
        responseDescription(descriptionSuitableForTestResult(response)).data());

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1223
> +    // TODO: add "has MIME type" whenever dumpResourceResponseMIMETypes()

I think this one is missing a word. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.