[Webkit-unassigned] [Bug 60666] Add hook to create arbitrary Storage objects from Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60666


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93189|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-05-11 15:12:33 PST ---
(From update of attachment 93189)
View in context: https://bugs.webkit.org/attachment.cgi?id=93189&action=review

> Source/WebKit/chromium/public/WebFrame.h:2
> - * Copyright (C) 2009 Google Inc. All rights reserved.
> + * Copyright (C) 2011 Google Inc. All rights reserved.

WebKit style is to append years to the copyright lines (or just leave them along).

> Source/WebKit/chromium/public/WebFrame.h:280
> +    // Creates a Storage object for the given origin, which need not match the
> +    // current page's origin.
> +    virtual v8::Handle<v8::Value> getStorageForOrigin(const WebSecurityOrigin&) = 0;

This just seems like piling junk onto WebFrame.

> Source/WebKit/chromium/public/WebSecurityOrigin.h:62
> +    WEBKIT_API static WebSecurityOrigin create(const WebString& protocol, const WebString& host, int port);

This API shouldn't exist.  You should just use a URL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.