[Webkit-unassigned] [Bug 60583] DOMFileSystemBase should not impose file naming restrictions on 'external' filesystems

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60583





--- Comment #8 from Zelidrag Hornung <zelidrag at chromium.org>  2011-05-11 13:29:31 PST ---
(From update of attachment 93012)
View in context: https://bugs.webkit.org/attachment.cgi?id=93012&action=review

>>> Source/WebCore/ChangeLog:10
>>> +        No new tests. (OOPS!)
>> 
>> This will make the commit-queue fail. You should explain why there are no new tests (is testing impossible here?)  or you should add tests.
>> 
>> Also, the FileSystem feature should be announced on webkit-dev per the new feature guidelines:
>> http://www.webkit.org/coding/adding-features.html
> 
> Oh, is the guideline applied to the features that are already being experimented/tested?  Well it'd be better to make this experimental feature more visible and to request more comments...
> Ok I'll be sending out an announce to webkit-dev.

done

>> Source/WebCore/fileapi/DOMFileSystemBase.cpp:148
>> +    if (type != AsyncFileSystem::External && !DOMFilePath::isValidPath(absolutePath))
> 
> if ((type == Temporary || type == Persistent) && !DOMFilePath::isValidPath())
> 
> might be better?  This is for basic checks that are explicitly noted in the spec (draft), therefore performing the checks for FS types that are spec'ed out would make more sense.

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.