[Webkit-unassigned] [Bug 60361] [EFL] EWebLauncher creates only one settings databases directory at startup.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 11 12:15:33 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60361





--- Comment #10 from Tomasz Morawski <t.morawski at samsung.com>  2011-05-11 12:15:32 PST ---
(In reply to comment #9)
> Could you explain why you added the stat()/S_ISDIR()/access() calls? WebCore::makeAllDirectories() already performs some access() calls besides calling mkdir() itself, so if you really want to ensure more information about the created path, IMO the changes should go there, not here.

If you give a path that point to a directory that already exist (even if the proces doesn't have rights to read or write to it) or to a file. The makeAllDirectory will return true. What is good because the path exist. No directory is needed to create.  So, additional checking is needed in our code to test if given path is a directory and if the proces have rights to write and read.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list