[Webkit-unassigned] [Bug 60527] Return empty Favicon URL instead of default one when the frame isn't top level one.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60527





--- Comment #8 from Tony Gentilcore <tonyg at chromium.org>  2011-05-11 09:10:02 PST ---
(From update of attachment 93127)
View in context: https://bugs.webkit.org/attachment.cgi?id=93127&action=review

> Source/WebCore/ChangeLog:16
> +        This issue was discussed by chromium browser test.

Maybe "discovered" instead of "discussed"?

So I guess that means there isn't a good way to test this in WebKit, but at least some ports might have coverage?

> Source/WebCore/loader/FrameLoader.cpp:478
> +    // If this isn't a top level frame, return

I'd just remove this comment now. It basically restates the code below without answering the question "why".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.