[Webkit-unassigned] [Bug 60602] An <output> element with display:block can be focused if you try to tab to it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 10 23:03:10 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60602





--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-05-10 23:03:10 PST ---
(From update of attachment 93075)
View in context: https://bugs.webkit.org/attachment.cgi?id=93075&action=review

> LayoutTests/ChangeLog:5
> +        An <output> element with display:block can be focused if you try to tab to it

The summary doesn't match the code change.  We should mention <meter> and <progress>.

> LayoutTests/fast/forms/focus-with-display-block-expected.txt:9
> + Output
> +
> +INPUT has focus.
> +INPUT has focus.
> +INPUT has focus.
> +INPUT has focus.
> +PASS

The test result readability is not good.
 - "Output" makes no sense.
 - The test result doesn't show what is succeeded.  We had better have lines such as "METER should not have focus."

> LayoutTests/fast/forms/focus-with-display-block.html:52
> +function test() {
> +    if (window.layoutTestController)
> +        layoutTestController.dumpAsText();
> +
> +    var results = document.getElementById('results');
> +    if (doTest())
> +        results.innerHTML += 'PASS';
> +    else
> +        results.innerHTML += 'FAIL';
> +}

We had better use functions in fast/js/resources/js-test-pre.js.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list