[Webkit-unassigned] [Bug 56301] chrome.dll!WebCore::RenderBlock::removeFloatingObjectsBelow ReadAV at NULL (928f227631041a7b4b71dd15efeae337)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56301





--- Comment #3 from Alexis Menard <alexis.menard at openbossa.org>  2011-05-10 15:23:59 PST ---
(From update of attachment 89726)
View in context: https://bugs.webkit.org/attachment.cgi?id=89726&action=review

The fix itself looks good though.

> Source/WebCore/ChangeLog:9
> +        an empty set. Also have some style fixes for class FloatingObjects.

The style fixes should be probably committed as a separate patch.

> Source/WebCore/ChangeLog:11
> +        No new tests, relying on existing layout tests.

But do they actually cover the problem? I believe no, so it would be nice to write one which covers the crash.

> Source/WebCore/rendering/RenderBlock.cpp:139
> +

This code is the same as the one you removed below. Why this change? It makes the diff harder to read and introduces changes for nothing, making hard for people to blame for example. Could you please fix that? Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.