[Webkit-unassigned] [Bug 60361] [EFL] EWebLauncher creates only one settings databases directory at startup.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 10 10:24:44 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60361





--- Comment #6 from Luiz Agostini <luiz at webkit.org>  2011-05-10 10:24:44 PST ---
(In reply to comment #5)
> Thank you for your comments.
> 
> > codding style: (const char *settings_db_path)
> Could you tell me what is wrong? I don't see what I have done wrong. Thare are many parameters name in this style in our headers. 

It is just about the * that should be at the type side. it should be char* instead of char *.
And you should avoid underlines as well.

> 
> > > Source/WebKit/efl/ewk/ewk_main.cpp:197
> > > +    if (!settings_db_path) {
> > 
> > Since you are creating the temp directory and returning from main() if temp directory creation fails, then it seems that all the code inside this if is dead code. Is it?
> > Would not be better to make the decision about which directory to use in main and make parameter settings_db_path obligatory?
> This is good idea but I have decided to not to make revolution in the code. But with pleasure I will do it. :) 

If it is about leaving dead code then I think that you should.

> 
> > > Source/WebKit/efl/ewk/ewk_main.cpp:201
> > > +        // check home directory first
> > 
> > codding style: // Check home directory first.
> > 
> > > Source/WebKit/efl/ewk/ewk_main.cpp:203
> > > +            // Exit now - otherwise you may have some crash later
> > 
> > codding style: missing period at the end of comment.
> This is an old code... anyways what is wrong? Only missing dot at the end of comment?

Comments should start with a capital letter and end with a period.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list