[Webkit-unassigned] [Bug 49543] [GTK] Improve FrameLoader signals. Resource loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49543





--- Comment #20 from Sergio Villar Senin <svillar at igalia.com>  2011-05-10 10:18:41 PST ---
(In reply to comment #19)
> (From update of attachment 92777 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92777&action=review
> 
> Awesome! This looks good to me. Please see my comments below, which comprise mostly stylistic nits. We need to get tha approval of another GTK+ reviewer for this.
> 
> > Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:-389
> > -    if (!redirectResponse.isNull()) {
> > -        // This is a redirect, so we need to update the WebResource's knowledge
> > -        // of the URI.
> > -        g_free(webResource->priv->uri);
> > -        webResource->priv->uri = g_strdup(request.url().string().utf8().data());
> > -    }
> > -    

I don't remember the exact details here but when I checked with test results it looked like all of them were assuming that web resources should have the original URL and not the redirected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.