[Webkit-unassigned] [Bug 60174] Fix getUserMedia callback bindings for JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60174





--- Comment #9 from Darin Adler <darin at apple.com>  2011-05-10 09:30:26 PST ---
(From update of attachment 92619)
View in context: https://bugs.webkit.org/attachment.cgi?id=92619&action=review

> Source/WebCore/bindings/js/JSNavigatorCustom.cpp:43
> +    if (exec->argumentCount() < 2) {
> +        setDOMException(exec, TYPE_MISMATCH_ERR);
> +        return jsUndefined();
> +    }

The desired behavior here, then, is that undefined turns into "undefined" for options, but that a missing argument yields TYPE_MISMATCH_ERR?

Similarly, I’m surprised that undefined for successCallback has different behavior than a missing argument, given that the missing argument behavior is TYPE_MISMATCH_ERR.

I’m a little surprised by these. Are they really covered by existing tests? I don’t see tests that are passing undefined.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.