[Webkit-unassigned] [Bug 60518] Expose willStartLiveResize and willEndLiveResize in WebView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 10 09:07:41 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60518





--- Comment #12 from Sailesh Agrawal <sail at chromium.org>  2011-05-10 09:07:41 PST ---
(From update of attachment 92890)
View in context: https://bugs.webkit.org/attachment.cgi?id=92890&action=review

>> Source/WebKit/chromium/public/WebView.h:136
>> +    // Notification that the view has started or ended live resize.
> 
> Maybe add "This is Mac-speak for when the user manuall resizes the window by dragging its corner." or something like this.

Done.

>> Source/WebKit/chromium/public/WebView.h:137
>> +    virtual void willStartLiveResize() = 0;
> 
> maybe you want to more explicitly mention the "resizer" in this API?  didStartDraggingResizer?  didStopDraggingResizer?
> 
> we already have the term "resizer" in the API.  see WebWidgetClient::windowResizerRect().
> 
> i'm a little concerned about using a OSX specific term here for something that could be generic to more ports.

As Nico mentioned, liveResize matches the naming in WebCore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list