[Webkit-unassigned] [Bug 54417] [chromium] Add a basic gesture recognizer to the Chromium platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54417





--- Comment #6 from Robert Kroeger <rjkroege at chromium.org>  2011-05-10 08:59:34 PST ---
(In reply to comment #4)
> (From update of attachment 92841 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92841&action=review
> 
> I don't really understand gestures, so the below are just general nits.  

nits addressed in patch3.

> Also, none of this code seems to be Chromium specific.  Perhaps it shouldn't be Chromium specific?  As an example, WebKit has image decodes that are used by some (but not all) platforms.  This seems like a general platform-agnostic implementation that some ports might want to replace with native gesture managers.  As such, it shouldn't be in Chromium-specific files.

My understanding of review comments from the previous patch in this sequence is that the reviewers were strongly of the opinion that even though this gesture recognizer is platform agnostic, it should remain specific to the Chromium platform until desired by other platforms.

Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.