[Webkit-unassigned] [Bug 60247] Handle the touch icon in WebKit/Chromium

Tue May 10 08:23:23 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=60247

Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92836|                            |review-
               Flag|                            |

--- Comment #24 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-05-10 08:23:22 PST ---
(From update of attachment 92836)
View in context: https://bugs.webkit.org/attachment.cgi?id=92836&action=review

> Source/WebKit/chromium/public/WebFrame.h:135
> +    virtual WebVector<WebIconURL> favIconURL(int iconTypes) const = 0;

you should explain what this mysterious int parameter is.  it is not obviously a bit-mask of Type enum values.  you should say so!

> Source/WebKit/chromium/public/WebIconURL.h:40
> +    enum WebIconType {

because this enum is nested inside a class, it does not need the redundant WebIcon prefix.  if you look around at other headers, you will see that this should just be enum Type { TypeInvalid = 0, ... };

> Source/WebKit/chromium/src/WebFrameImpl.cpp:529
> +        WTF::Vector<WebCore::IconURL> iconURLs = frameLoader->iconURLs(webIconTypes);

no WTF:: in .cpp files

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.