[Webkit-unassigned] [Bug 59017] [GTK] Implement History API FrameLoaderClient methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 18:28:38 PDT 2011


--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2011-05-09 18:28:39 PST ---
(In reply to comment #6)
> Dumping here some comments Martin and I had about this on jabber:
> - If we commit the patch as-is we break at least one invariant our code had before: we'll emit a provisional load signal without having a provisional data source/request. In theory this cannot happen.
> - If we skip the provisional stage this to avoid the former, we break another invariant: we go through committed and finished before having started at provisional. I believe this, also, cannot happen in theory.
> So I'm having second thoughts about this. If I had to choose I'd probably decide to go for option a). CCing Gustavo in case he wants to comment.

We can create a fake provisional data source/request, perhaps? Even if we don't, I think the first option is the one with less chance of causing breakage, so I'd go with it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list