[Webkit-unassigned] [Bug 57543] -webkit-visual-word does not work on words separated by multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57543





--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2011-05-09 16:03:39 PST ---
(In reply to comment #11)
> We did not expose whether the word break is before a word or after a word in the function names of ....WithSameDirectionality() and ....WithDifferentDirectionality() and their callee.
> Inside previousWordBreakInBoxInsideBlockWithSameDirectionality() and nextWordBreakInBoxInsideBlockWithDifferentDirectionality(), there is comment saying where the word break should be, those functions and their callees follow the rule.

That's bad :(

> >> Source/WebCore/editing/visible_units.cpp:1162
> >> +    VisiblePosition nextWord = nextWordPosition(wordBreak);
> > 
> > Nit: s/nextWord/positionAfterCurrentWord/
> 
> It could be positionAfterCurrentWord or positionAfterNextWord. Maybe change 'wordBreak' to 'visiblePosition" and change 'nextWord' to 'positionAfterWordBreak'.

positionAfterWord.  WordBreak, by definition, is before or after a word and it's redundant.

> >> Source/WebCore/editing/visible_units.cpp:1163
> >> +    VisiblePosition wordPosition = previousWordPosition(nextWord);
> > 
> > Nit: s/wordPosition/positionBeforeCurrentWord/
> 
> maybe s/wordPosition/positionBeforeWordBreak/?

Ditto; positionBeforeWord

> > But your condition says box->isLTR() AND box->nextLeafChild().  Under this condition, the box is not the rightmost box.
> 
> We need to collect the rightmost word break if the box is *not* the rightmost box. And we do *not* need to collect the rightmost word break if the box is the rightmost box.

Why is that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.