[Webkit-unassigned] [Bug 60396] Add RIAA-style DenormalDisabler class to disable denormals which hurt audio performance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60396


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92834|review?                     |review+
               Flag|                            |




--- Comment #12 from Kenneth Russell <kbr at google.com>  2011-05-09 14:59:19 PST ---
(From update of attachment 92834)
View in context: https://bugs.webkit.org/attachment.cgi?id=92834&action=review

Couple of minor comments; feel free to fix upon landing.

> Source/WebCore/ChangeLog:5
> +        Add RIAA-style DenormalDisabler class to disable denormals which hurt audio performance.

RIAA -> RAII

> Source/WebCore/platform/audio/DenormalDisabler.h:50
> +        asm volatile("stmxcsr %0" : "=m" (*&result));

It looks like the *& isn't needed here or on the ldmxcsr; see http://gcc.gnu.org/bugzilla/attachment.cgi?id=11062 .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.