[Webkit-unassigned] [Bug 60466] check-webkit-style didn't flag XML syntax errors in r86047

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60466





--- Comment #3 from David Levin <levin at chromium.org>  2011-05-09 13:08:50 PST ---
(In reply to comment #2)
> (In reply to comment #0)
> > Attachment 92746 [details] [details] in bug 54181 contained XML syntax errors in WebCore.vcproj. check-webkit-style didn't flag those errors, so the buggy patch was committed in r86047. I had to land a fix in r86052 to fix them.
> > 
> > We should figure out why check-webkit-style didn't flag the errors.
> 
> I suspect this has to do with the fact that it filters to only be on the lines where changes were made. In general, this is really good, but for some checkers like the xml one, it probably shouldn't happen.

Yep, that was it. Patching coming shortly. The test expectations checker had the same issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.