[Webkit-unassigned] [Bug 60487] [Qt] DRT eventSender.addTouchPoint method is not setting the start position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60487


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92814|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Andreas Kling <kling at webkit.org>  2011-05-09 12:36:31 PST ---
(From update of attachment 92814)
View in context: https://bugs.webkit.org/attachment.cgi?id=92814&action=review

Nice catch. r- because the code is ugly. Not your fault, but let's fix it. :)

> Tools/DumpRenderTree/qt/EventSenderQt.cpp:406
>      QTouchEvent::TouchPoint point(id);
>      m_touchPoints.append(point);
>      updateTouchPoint(index, x, y);
> +    m_touchPoints[index].setStartPos(QPointF(x, y));
>      m_touchPoints[index].setState(Qt::TouchPointPressed);

This code is unnecessarily confusing, we should fix it while we're visiting. Something like:

QTouchEvent::TouchPoint point(id);
point.setPos(QPointF(x, y));
point.setStartPos(QPointF(x, y));
point.setState(Qt::TouchPointPressed);
m_touchPoints.append(point);

And of course the 'index' variable won't be needed after this cleanup.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.