[Webkit-unassigned] [Bug 60409] Convert x, y and width, height pairs to IntPoint and IntSize for RenderLayer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 9 12:35:39 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60409


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92827|review?                     |review+
               Flag|                            |




--- Comment #11 from Eric Seidel <eric at webkit.org>  2011-05-09 12:35:39 PST ---
(From update of attachment 92827)
View in context: https://bugs.webkit.org/attachment.cgi?id=92827&action=review

Fantastic!

> Source/WebCore/rendering/RenderLayer.cpp:1335
> +    IntSize newScrollOffset = IntSize(x - m_scrollOrigin.x(), y - m_scrollOrigin.y());

I might have written this as IntPoint(x, y) - m_scrollOrigin, on the assumption that eventually this function will take a point instead of an int pair.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list