[Webkit-unassigned] [Bug 60177] Media Stream API: add local stream requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60177





--- Comment #8 from Leandro Graciá Gil <leandrogracia at chromium.org>  2011-05-09 08:47:56 PST ---
(From update of attachment 92632)
View in context: https://bugs.webkit.org/attachment.cgi?id=92632&action=review

>> Source/WebCore/page/MediaStreamFrameController.cpp:110
>> +    while (!this->isEmpty())
> 
> Since there is a comment, this loop should have {} braces.

Fixed.

>> Source/WebCore/page/MediaStreamFrameController.cpp:111
>> +        // unregister should remove the element from the map.
> 
> Is there some way to ASSERT this? If it doesn't, this could just spin forever.

Fixed.

>> Source/WebCore/page/MediaStreamFrameController.cpp:250
>> +    ec = 0;
> 
> Should this be the first line in the method so that if (!successCallback) is reached, then ec is cleared?

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.