[Webkit-unassigned] [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60439





--- Comment #36 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-05-08 09:51:52 PST ---
(In reply to comment #31)
> (From update of attachment 92721 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92721&action=review
> 
> > Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:69
> > +        if (m_frame->d)
Fair enough

> Does the frame not always have a private? You dont test for this elsewhere
> 
> > Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:293
> > +        textureMapperNodeClient = new TextureMapperNodeClientQt(page->mainFrame(), layer);
> 
> Can't we use an OwnPtr?
OK

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.