[Webkit-unassigned] [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 8 05:43:08 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=60439
--- Comment #31 from Kenneth Rohde Christiansen <kenneth at webkit.org> 2011-05-08 05:43:08 PST ---
(From update of attachment 92721)
View in context: https://bugs.webkit.org/attachment.cgi?id=92721&action=review
> Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:69
> + if (m_frame->d)
Does the frame not always have a private? You dont test for this elsewhere
> Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:293
> + textureMapperNodeClient = new TextureMapperNodeClientQt(page->mainFrame(), layer);
Can't we use an OwnPtr?
> Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp:305
> + delete textureMapperNodeClient;
> + textureMapperNodeClient = 0;
OwnPtr?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list