[Webkit-unassigned] [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60439


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92712|review?                     |review+
               Flag|                            |




--- Comment #29 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-05-08 04:49:04 PST ---
(From update of attachment 92712)
View in context: https://bugs.webkit.org/attachment.cgi?id=92712&action=review

r+ if you fix my comments

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:615
> +void MediaPlayerPrivateQt::paintToTextureMapper(TextureMapper* textureMapper,
> +                           const FloatRect& targetRect,
> +                           const TransformationMatrix& matrix,
> +                           float opacity,
> +                           BitmapTexture*) const

Please put on one line before committing!

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:115
> +    virtual void paintToTextureMapper(TextureMapper*,
> +                       const FloatRect& targetRect,
> +                       const TransformationMatrix&,
> +                       float opacity,
> +                       BitmapTexture* mask) const;

One line please

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.