[Webkit-unassigned] [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch

Sun May 8 04:37:42 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=60439

Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92708|review?                     |review+
               Flag|                            |

--- Comment #26 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-05-08 04:37:42 PST ---
(From update of attachment 92708)
View in context: https://bugs.webkit.org/attachment.cgi?id=92708&action=review

> Source/WebCore/ChangeLog:11
> +        1. an entry/exit point for painting (beginPaint/endPaint)

An*

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:97
> +    virtual void drawTexture(const BitmapTexture&, const FloatRect& target, const TransformationMatrix& modelViewMatrix = TransformationMatrix(), float opacity = 1.0f, const BitmapTexture* maskTexture = 0) = 0;

im not sure that the modelView adds value, it actually just make it more confusing to me

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:108
> +    void setViewportSize(const IntSize& s) { m_viewportSize = s; }

I think writing size makes more sense

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.