[Webkit-unassigned] [Bug 60380] Fix compile with gcc 4.6.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 7 15:55:15 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60380


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92698|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #13 from Daniel Bates <dbates at webkit.org>  2011-05-07 15:55:15 PST ---
(From update of attachment 92698)
View in context: https://bugs.webkit.org/attachment.cgi?id=92698&action=review

As far as I can tell you're not a committer. So, I will make these changes for you and land your patch.

> Source/JavaScriptCore/ChangeLog:8
> +        Remove unused local variable from code
> +
> +        Fix compile with gcc 4.6.0
> +        https://bugs.webkit.org/show_bug.cgi?id=60380

This change log entry does not have the right format. The format is bug title, bug url, then description. Also, GCC is an acronym so "gcc" should be "GCC" (although I can see from the diff that we landed change log entries with "gcc").

Also, we use complete sentences.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list