[Webkit-unassigned] [Bug 60409] Convert x, y and width, height pairs to IntPoint and IntSize for RenderLayer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60409





--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-05-07 10:15:40 PST ---
(From update of attachment 92670)
View in context: https://bugs.webkit.org/attachment.cgi?id=92670&action=review

This is a good start.

> Source/WebCore/rendering/RenderLayer.cpp:718
> +        m_relativeOffset.setWidth(renderer()->relativePositionOffsetX());
> +        m_relativeOffset.setHeight(renderer()->relativePositionOffsetY());

Seems like the renderer should have relativePositionOffset()

> Source/WebCore/rendering/RenderLayer.h:224
> +    IntSize size() const { return m_layerSize; }

This could return const IntSize&

> Source/WebCore/rendering/RenderLayer.h:237
> +    IntSize scrolledContentOffset() const { return IntSize(scrollXOffset() + m_scrollOverflow.width(), scrollYOffset() + m_scrollOverflow.height()); }

Would be nice to do this math entirely in IntSize/IntPoint.

> Source/WebCore/rendering/RenderLayer.h:310
> +    IntSize relativePositionOffset() const { return m_relativeOffset; }

Could return const IntSize&

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.