[Webkit-unassigned] [Bug 60010] [Chromium]Add clear_autofill flag to hide autofill popup without clear field.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 7 02:05:14 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=60010
--- Comment #13 from Ilya Sherman <isherman at chromium.org> 2011-05-07 02:05:15 PST ---
(From update of attachment 92677)
View in context: https://bugs.webkit.org/attachment.cgi?id=92677&action=review
This looks ok to me, but should definitely get looked at by one of the WebKit API guardians.
> Source/WebCore/ChangeLog:5
> + [Chromium]Add clear_autofill flag to hide autofill popup without clear field.
nit: This description is out of sync with the code changes.
> Source/WebKit/chromium/public/WebView.h:301
> + virtual void acceptCurrectAutoFilled() = 0;
nit: Is there any reason not to name this more generally, e.g. """ acceptSelectedPopupItem() """ ?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list