[Webkit-unassigned] [Bug 60361] [EFL] EWebLauncher creates only one settings databases directory at startup.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60361





--- Comment #4 from Luiz Agostini <luiz at webkit.org>  2011-05-06 15:07:09 PST ---
(From update of attachment 92569)
View in context: https://bugs.webkit.org/attachment.cgi?id=92569&action=review

> Source/WebKit/efl/ewk/ewk_main.cpp:66
> +static Eina_Bool _ewk_init_body(const char *settings_db_path);

codding style: (const char* settings_db_path)

> Source/WebKit/efl/ewk/ewk_main.cpp:80
> +int ewk_init(const char *settings_db_path)

The same here.

> Source/WebKit/efl/ewk/ewk_main.cpp:166
> +Eina_Bool _ewk_init_body(const char *settings_db_path)

And here.

> Source/WebKit/efl/ewk/ewk_main.cpp:197
> +    if (!settings_db_path) {

Since you are creating the temp directory and returning from main() if temp directory creation fails, then it seems that all the code inside this if is dead code. Is it?
Would not be better to make the decision about which directory to use in main and make parameter settings_db_path obligatory?

> Source/WebKit/efl/ewk/ewk_main.cpp:201
> +        // check home directory first

codding style: // Check home directory first.

> Source/WebKit/efl/ewk/ewk_main.cpp:203
> +            // Exit now - otherwise you may have some crash later

codding style: missing period at the end of comment.

> Source/WebKit/efl/ewk/ewk_main.cpp:205
> +            CRITICAL("Can't access HOME dir (or /tmp) %s - no place to save databases: %s", path.utf8().data(), strerror(errnowas));

Why are you mentioning /temp if you made path = WebCore::homeDirectoryPath()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.