[Webkit-unassigned] [Bug 60269] [Windows, WinCairo] Implement ability to add C++ event listeners to html dom elements and dom window

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 14:23:06 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60269





--- Comment #23 from Brent Fulgham <bfulgham at webkit.org>  2011-05-06 14:23:06 PST ---
(In reply to comment #20)
> > What is your plan for this logic?  I assume this is copied from the Cocoa implementation.  Is there an analogous method we can be calling in our C++ code?
> > 
> > > DOMCoreClasses.cpp:941
> > > +    WebCore::raiseOnDOMError(ec);
> > 
> > Is this not implemented in C++?  Why is it commented out?
> > 
> 
> It seems like my annotation comments don't generate a new entry in the main comment stream. Anyway, in case you didn't see my reply on that, the code was a straight copy from DOMNode::dispatchEvent() at line 429. I only changed m_node to m_window, and left everything else the same. Being a newbie, I'm going for least impact.

Ah!  Makes sense.  Let's see if we can find ggaren/ap/aroben to finish this review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list