[Webkit-unassigned] [Bug 60269] [Windows, WinCairo] Implement ability to add C++ event listeners to html dom elements and dom window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60269





--- Comment #17 from Brent Fulgham <bfulgham at webkit.org>  2011-05-06 13:27:59 PST ---
(From update of attachment 92613)
View in context: https://bugs.webkit.org/attachment.cgi?id=92613&action=review

This looks great.  I hope we can land this soon, as this would be useful in a variety of contexts!

> DOMCoreClasses.cpp:409
> +	RefPtr<WebEventListener> cpplistener = WebEventListener::create(listener);

I'd change 'cpplistener' to 'webListener'

> DOMCoreClasses.cpp:421
> +		return E_POINTER;

Extra indention

> DOMCoreClasses.cpp:424
> +    RefPtr<WebEventListener> cpplistener = WebEventListener::create(listener);

Ditto: 'cpplistener' -> 'webListener'

> DOMCoreClasses.cpp:434
> +		return E_POINTER;

Ditto: indent

> DOMCoreClasses.cpp:897
> +		return E_POINTER;

Ditto: Indent

> DOMCoreClasses.cpp:900
> +    RefPtr<WebEventListener> cppListener = adoptRef(new WebEventListener(listener));

cppListener -> webListener

> DOMCoreClasses.cpp:911
> +		return E_POINTER;

Ditto: Indent

> DOMCoreClasses.cpp:914
> +	RefPtr<WebEventListener> cpplistener = WebEventListener::create(listener);

Ditto: cppListener -> webListener

> DOMCoreClasses.cpp:929
> +    if (![self _node]->isEventTargetNode())

What is your plan for this logic?  I assume this is copied from the Cocoa implementation.  Is there an analogous method we can be calling in our C++ code?

> DOMCoreClasses.cpp:941
> +    WebCore::raiseOnDOMError(ec);

Is this not implemented in C++?  Why is it commented out?

> DOMEventsClasses.cpp:63
> +}

Style guide requires an empty line between these implementations.

> DOMEventsClasses.cpp:67
> +}

Ditto

> DOMEventsClasses.cpp:72
> +}

Ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.