[Webkit-unassigned] [Bug 60174] Fix getUserMedia callback bindings for JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60174


Adam Bergkvist <adam.bergkvist at ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92255|0                           |1
        is obsolete|                            |
  Attachment #92619|                            |review?
               Flag|                            |




--- Comment #8 from Adam Bergkvist <adam.bergkvist at ericsson.com>  2011-05-06 12:09:24 PST ---
Created an attachment (id=92619)
 --> (https://bugs.webkit.org/attachment.cgi?id=92619&action=review)
Updated patch

The problem can be solved while still using generated bindings. However, the currently generated bindings fail due to a callback argument not being translated correctly resulting in the handleEvent() function not being overridden as it should (argument mismatch between int and int*). To avoid updating the JSC bindings generator, the fix was to change the failing "dummy" argument type to DOMString since primitive number types are not supported as callback arguments. Also, in the webkitGetUserMedia() custom binding the argument count is checked before trying to convert the first argument (fixes a failure in the argument-types test).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.