[Webkit-unassigned] [Bug 60247] Handle the touch icon in WebKit/Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60247





--- Comment #6 from michaelbai at chromium.org  2011-05-06 10:44:18 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 92469 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=92469&action=review
> > > > Source/WebKit/chromium/src/WebIconTypeUtilities.h:43
> > > > +    static int ToIconTypes(int);
> > > 
> > > Ditto. Also there should be a variable name here. The variable name is only left out when it is obviously redundant with the information already on the line. This is not the case for the input "int".
> > 
> > Done, How do I suppress the style check error, I used to have the variable name here.
> 
> No style error :) (The style checker looks for name overlapping with the type given. That doesn't happen here. It also does some special checks for "set" functions but that isn't the case here either.)
> 
> You likely got style errors on the other lines where the variable name was redundant with the type.

You are right. It passed the check. I got the style error in different line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.