[Webkit-unassigned] [Bug 60373] check-webkit-style / TestExpectationChecker doesn't catch all parse errors in test_expectations.txt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60373





--- Comment #4 from David Levin <levin at chromium.org>  2011-05-06 10:07:07 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > Another approach is to simply test_expectations to the point where it cannot have parse errors.
> 
> This bug was prompted by http://trac.webkit.org/changeset/85950, which fixed what was called a parse error, but it was really a cuplicate expectation where one was more specific than the other.
> 
> On further inspection, it looks like check-webkit-style will complain about "duplicate or ambiguous expectation" but only if both offending lines are in the patch.  Maybe it needs to consider the whole file?

In general, check-webkit-style only complains about the line that you changed. However, I'm sure one could change this for a particular checker.

Patches welcome :).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.