[Webkit-unassigned] [Bug 60368] [GTK] Implement NetscapePlugin::platformPaint for GTK platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60368





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-05-06 08:54:58 PST ---
(In reply to comment #2)
> (From update of attachment 92577 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92577&action=review
> 
> Looking good. Just a couple comments.
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:224
> > +#elif PLATFORM(GTK)
> > +    RefPtr<cairo_surface_t> drawableSurface = adoptRef(cairo_xlib_surface_create(x11Display(),
> > +                                                                                 m_drawable,
> > +                                                                                 static_cast<NPSetWindowCallbackStruct*>(m_npWindow.ws_info)->visual,
> > +                                                                                 m_frameRect.width(),
> > +                                                                                 m_frameRect.height()));
> 
> Wouldn't it be better to wrap this surface in a Cairo surface after the calls to NPP_HandleEvent and XSync, like Qt?

I'm not sure I understand what you mean by "wrap this surface in a Cairo surface". I tried to follow the current webkit1 approach.

> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:267
> > +    cairo_rectangle(cr,
> > +                    m_frameRect.x() + exposedRect.x(), m_frameRect.y() + exposedRect.y(),
> > +                    exposedRect.width(), exposedRect.height());
> 
> Do you mind just putting this one on one line? 120 character is generally okay. Sorry for the nit. :)

Sure, no problem

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.