[Webkit-unassigned] [Bug 57138] WebSocket urls should always be encoded as UTF-8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57138





--- Comment #15 from Joe Mason <jmason at rim.com>  2011-05-05 23:17:51 PST ---
(In reply to comment #13)
> (From update of attachment 92543 [details])
> +        // Use a String instead of a KURL for the url to ensure that WebSocket
> +        // parses the url itself using WebSocket rules (must be absolute and
> +        // UTF-8 encoded).
> 
> I don't see how the comment can be useful to someone reading this code. There is no option to use KURL, so explaining why String is better than KURL is pointless.
> 
> Otherwise, looks fine to me. Adam?

My thought is that people looking at it will wonder, "If it's a url, why isn't a KURL?" so an explanation is valuable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.